serve_locally by default #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcjohnson
commented
May 16, 2019
| # pylint: disable=no-init, too-few-public-methods | ||
| class config: | ||
| infer_from_layout = True | ||
| serve_locally = False |
There was a problem hiding this comment.
The way we did this before, despite the fact that Scripts was instantiated, Scripts.config was a singleton. Mostly this is OK, dunno if there will ever be a reason to put two Scripts instances in one Python session, but it caused our test cases to be coupled to each other. I had to change this to an instance when I took out all the otherwise superfluous overrides in our test cases.
24 tasks
tests/test_resources.py
Outdated
| @@ -48,6 +48,7 @@ def test_external(self): | |||
| ) | |||
| app.layout = dcc.Markdown() | |||
| app.scripts.config.serve_locally = False | |||
| app.scripts.config.xxx = 123 | |||
There was a problem hiding this comment.
Senator, I do not recall.
c096aa1
There was a problem hiding this comment.
I saw it at the time and had assumed it was to test for acceptance of randomly-named config keys :)
|
diffs look like noise.. 🙄 |
HammadTheOne
pushed a commit
to HammadTheOne/dash
that referenced
this pull request
May 28, 2021
HammadTheOne
pushed a commit
to HammadTheOne/dash
that referenced
this pull request
May 28, 2021
HammadTheOne
pushed a commit
that referenced
this pull request
Jul 23, 2021
HammadTheOne
pushed a commit
that referenced
this pull request
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flipping one of the remaining switches for #469
Closes #284
Closes https://github.com/plotly/dash-core/issues/10